Use STL containers when requiring pointer/iterator stability #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://abseil.io/about/design/btree:
BinDiff incorrectly relies on pointer stability and iterator stability when using btree data structures in a number of places:
indexed_fixed_points_
is a vector of pointers toFixedPointInfo
s held in aabsl::btree_set
indexed_flow_graphs1_
andindexed_flow_graphs2_
are vectors of pointers toFlowGraphInfo
s held in aabsl::btree_map
Results::DeleteMatches
callshistogram_.erase
while iterating overhistogram_
which is aabsl::btree_map
, invalidating the iteratorYou can see the effects of these incorrect assumptions by manually removing and adding matches in the IDA plugin. You will see duplicate matches appearing and functions being erased from the database entirely.
This PR fixes the issue by replacing the types that depend on pointer/iterator stability with their STL equivalents.