Add a little clarification about static factory methods versus record constructors. #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
… constructors. The text here was intended to be about the common case where your AutoValue class `Foo` has a single static factory method which calls the generated `AutoValue_Foo` constructor. Then if you replace `Foo` with a record, there's not a whole lot of benefit to maintaining the method, apart from easing migration. But one benefit is that methods have names. This is mostly relevant when you have _several_ static factory methods. RELNOTES=n/a PiperOrigin-RevId: 740873396
copybara-service
bot
force-pushed
the
test_main_740862336
branch
from
9b4202f to
a682925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a little clarification about static factory methods versus record constructors.
The text here was intended to be about the common case where your AutoValue class
Foohas a single static factory method which calls the generatedAutoValue_Fooconstructor. Then if you replaceFoowith a record, there's not a whole lot of benefit to maintaining the method, apart from easing migration. But one benefit is that methods have names. This is mostly relevant when you have several static factory methods.RELNOTES=n/a