Skip to content

Add text inputs support for Beam module #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mtsokol wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add text inputs support for Beam module #169

mtsokol wants to merge 1 commit into from

Conversation

@mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Jul 30, 2025

Hi @iindyk,

This PR adds support for text inputs for Beam module and cleans up Beam docs a bit.

@iindyk iindyk requested a review from dryman July 31, 2025 22:05
@iindyk
Copy link
Collaborator

iindyk commented Jul 31, 2025

@dryman Felix, please take a look

dryman
dryman suggested changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@dryman dryman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review.

Could you add a beam test for your changes in the pipeline? It makes your PR more solid and would prevent future code changes the intended behaviors.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dryman dryman dryman requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtsokol @iindyk @dryman