Sync protobuf version with TF for the OSX build. #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_788613087
branch
from
e5588bc to
c16b65d
Compare
PiperOrigin-RevId: 788613087
copybara-service
bot
force-pushed
the
test_788613087
branch
from
c16b65d to
2ddccab
Compare
mtsokol
reviewed
Aug 4, 2025
Comment on lines
+27
to
+31
| # TF proto version is protobuf-3.21.9, and per proto engdoc | ||
| # https://protobuf.dev/support/version-support/ | ||
| # The major version saparation happens at 21.x == 3.21 | ||
| # so we pick 21.7, which is the same generation as 3.21.9 | ||
| bazel_dep(name = "protobuf", version = "21.7") |
mtsokol
reviewed
Aug 4, 2025
| write_to_bazelrc "build --host_cxxopt=-std=c++17" | ||
| write_to_bazelrc "build --experimental_repo_remote_exec" | ||
| write_to_bazelrc "common --check_direct_dependencies=error" | ||
| # write_to_bazelrc "common --check_direct_dependencies=error" |
Contributor
There was a problem hiding this comment.
This breaks downstream, especially Grain, which installs a protobuf version that is incompatible with 21.7.
mtsokol
reviewed
Aug 4, 2025
Comment on lines
+94
to
+95
| # if [ "$(uname)" != "Darwin" ] && (( "${PYTHON_MINOR_VERSION}" < 13 )); then | ||
| if (( "${PYTHON_MINOR_VERSION}" < 13 )); then |
Contributor
There was a problem hiding this comment.
Once google/grain#954 is merged and Grain gets a pre-release we can actually have this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync protobuf version with TF for the OSX build.