Migrate DateViewFactory to compose #2879
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZRS
force-pushed
the
sdc-compose-date-view
branch
2 times, most recently
from
682f16e to
5488bfd
Compare
LZRS
force-pushed
the
sdc-compose-date-view
branch
from
9eb5df4 to
1c0bb48
Compare
LZRS
force-pushed
the
sdc-compose-date-view
branch
5 times, most recently
from
d527337 to
3b05b71
Compare
LZRS
force-pushed
the
sdc-compose-date-view
branch
2 times, most recently
from
3f5c7a9 to
708c675
Compare
LZRS
force-pushed
the
sdc-compose-date-view
branch
from
708c675 to
76c76f5
Compare
Instead of throwing an IllegalArgumentException
LZRS
force-pushed
the
sdc-compose-date-view
branch
from
76c76f5 to
25bb605
Compare
jingtang10
reviewed
Nov 6, 2025
| import androidx.compose.ui.text.input.TransformedText | ||
| import androidx.compose.ui.text.input.VisualTransformation | ||
|
|
||
| class DateVisualTransformation( |
Comment on lines
65
to
68
| var transformedText = "" | ||
| trimmedText.forEachIndexed { index, char -> | ||
| transformedText += char | ||
| if (index + 1 == firstDelimiterOffset || index + 2 == secondDelimiterOffset) { |
Collaborator
There was a problem hiding this comment.
please add documentation
To note; the ExposedDropdownMenuBox is specifically designed for displaying a list of selectable items within a menu, and not for triggering dialogs
LZRS
force-pushed
the
sdc-compose-date-view
branch
2 times, most recently
from
3589d01 to
2fc8e63
Compare
To simplify date formatting visualization and synchronization
LZRS
force-pushed
the
sdc-compose-date-view
branch
from
2fc8e63 to
268a71d
Compare
This reverts commit 268a71d.
LZRS
force-pushed
the
sdc-compose-date-view
branch
from
48f8fe4 to
5d3fe12
Compare
LZRS
force-pushed
the
sdc-compose-date-view
branch
from
5d3fe12 to
4fcf123
Compare
Collaborator
Author
|
Collaborator
Author
|
Collaborator
Author
|
jingtang10
approved these changes
Nov 26, 2025
Comment on lines
+267
to
+268
| val delimiterFirstIndex: Int = pattern.indexOf(delimiter) | ||
| val delimiterLastIndex: Int = pattern.lastIndexOf(delimiter) |
Collaborator
There was a problem hiding this comment.
just have a function that checks if a certain index is a delimiter?
|
|
||
| val delimiterFirstIndex: Int = pattern.indexOf(delimiter) | ||
| val delimiterLastIndex: Int = pattern.lastIndexOf(delimiter) | ||
| val delimiterExistsInPattern = delimiterFirstIndex != -1 && delimiterLastIndex != -1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| val delimiterExistsInPattern = delimiterFirstIndex != -1 && delimiterLastIndex != -1 | |
| val delimiterExistsInPattern = pattern.indexOf(delimiter) != -1 |
Comment on lines
+132
to
+138
| if ( | ||
| this.length > dateInputFormat.delimiterFirstIndex && | ||
| get(dateInputFormat.delimiterFirstIndex) != dateInputFormat.delimiter | ||
| ) { | ||
| insert(dateInputFormat.delimiterFirstIndex, dateInputFormat.delimiter) | ||
| } | ||
| if ( |
Collaborator
There was a problem hiding this comment.
should these 2 ifs collapse into 1? there's no difference between the first and last delimiters, just treat them the same way.
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2860
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.