Move the add button for repeated groups to bottom #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZRS
force-pushed
the
repeat_group_bottom_add_button
branch
3 times, most recently
from
13bc15a to
031d2f5
Compare
Screen_recording.mp4 |
LZRS
force-pushed
the
repeat_group_bottom_add_button
branch
from
031d2f5 to
57bdd88
Compare
jingtang10
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
thanks @LZRS - some comments but nothing on the functionalities this PR introduces. for that reason i'm going to approve and please feel free to merge once all comments are addressed.
...re/src/main/java/com/google/android/fhir/datacapture/views/RepeatedGroupAddItemViewHolder.kt
Show resolved
Hide resolved
Comment on lines
+1028
to
+1030
| if (questionnaireItem.isRepeatedGroup) { | ||
| add(QuestionnaireAdapterItem.RepeatedGroupAddButton(question.item)) | ||
| } |
There was a problem hiding this comment.
can you put this inside the buildList?
also udpate the comment right before the buildList function.
...src/androidTest/java/com/google/android/fhir/datacapture/test/QuestionnaireUiEspressoTest.kt
Outdated
Show resolved
Hide resolved
...src/androidTest/java/com/google/android/fhir/datacapture/test/QuestionnaireUiEspressoTest.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+390
to
+392
| oldItem.item.hasTheSameItem(newItem.item) && | ||
| oldItem.item.hasTheSameResponse(newItem.item) && | ||
| oldItem.item.hasTheSameValidationResult(newItem.item) |
There was a problem hiding this comment.
have you tested having 2 repeated groups?
| .inflate(R.layout.pagination_navigation_view, parent, false), | ||
| ) | ||
| QuestionnaireEditAdapter.ViewType.Type.REPEATED_GROUP_HEADER -> TODO() | ||
| QuestionnaireEditAdapter.ViewType.Type.REPEATED_GROUP_ADD_BUTTON -> TODO() |
There was a problem hiding this comment.
wouldn't this just crash? and is it crashing now for the line above REPEATED_GROUP_HEADER?
unless we filter out these items beforehand?
if we do filter them out correctly beforehand, then here it should throw an error. (illegal state exception).
| holder.bind(item.questionnaireNavigationUIState) | ||
| } | ||
| is QuestionnaireAdapterItem.RepeatedGroupHeader -> TODO() | ||
| is QuestionnaireAdapterItem.RepeatedGroupAddButton -> TODO() |
| subtype = 0xFFFFFF | ||
| } | ||
| is QuestionnaireAdapterItem.RepeatedGroupHeader -> TODO() | ||
| is QuestionnaireAdapterItem.RepeatedGroupAddButton -> TODO() |
...src/test/java/com/google/android/fhir/datacapture/views/RepeatsGroupAddItemViewHolderTest.kt
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
LZRS
force-pushed
the
repeat_group_bottom_add_button
branch
from
ae82ad8 to
e8c4aff
Compare
LZRS
force-pushed
the
repeat_group_bottom_add_button
branch
from
e8c4aff to
23ac82c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2844
Description
Sets the button to add repeated items at the bottom of the group. Clicking the add button prepends the repeated group item to come before the add button
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.