Fixed to prevent checkbox crashes#2661 #2800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
suggested changes
Mar 4, 2025
| "repeats": true, | ||
| "repeats": false, |
There was a problem hiding this comment.
this should be true, because this json example is intended to showcase checkbox widget
MJ1998
requested changes
Mar 4, 2025
Comment on lines
+130
to
+132
| if(!questionnaireViewItem.questionnaireItem.repeats){ | ||
| newAnswers.clear() | ||
| } |
There was a problem hiding this comment.
looks a bit odd place to add this logic - you are adding some item to newAnswers by clearing it ?
can you move this piece of code below - after getting newAnswers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2661
Description
fixed to prevent checkbox crashed.
I have cleared the checkbox list if repeat is false.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.