Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toSpanned in validation error dialog text #2798

Merged

Conversation

FikriMilano
Copy link
Collaborator

@FikriMilano FikriMilano commented Feb 24, 2025

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2797

Description
Use toSpanned in validation error dialog text

Alternative(s) considered
Another way is to remove the HTML, to only extract the text content.
But, just using toSpanned is much simpler.

Type
Bug fix

Screenshots (if applicable)
Screen Shot 2025-02-21 at 15 31 57

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@FikriMilano FikriMilano requested a review from a team as a code owner February 24, 2025 12:13
@MJ1998
Copy link
Collaborator

MJ1998 commented Mar 3, 2025

Can you run ./gradlew spotlessapply, @FikriMilano ?

@FikriMilano
Copy link
Collaborator Author

@MJ1998 spotless applied

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MJ1998 MJ1998 merged commit 0b73fb6 into google:master Mar 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw HTML shown in validation error dialog
3 participants