Join filter queries using Intersect and Union #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
approved these changes
Dec 11, 2024
engine/src/main/java/com/google/android/fhir/search/MoreSearch.kt
Outdated
Show resolved
Hide resolved
MJ1998
requested changes
Jan 28, 2025
Comment on lines
+1913
to
+1935
| SELECT a.resourceUuid, a.serializedResource | ||
| FROM ResourceEntity a | ||
| WHERE a.resourceUuid IN ( | ||
| SELECT resourceUuid FROM StringIndexEntity | ||
| WHERE resourceType = ? AND index_name = ? AND index_value = ? | ||
| UNION | ||
| SELECT resourceUuid FROM StringIndexEntity | ||
| WHERE resourceType = ? AND index_name = ? AND index_value = ? | ||
| INTERSECT | ||
| SELECT resourceUuid | ||
| FROM ResourceEntity a | ||
| WHERE a.resourceType = ? AND a.resourceId IN ( | ||
| SELECT substr(a.index_value, 9) | ||
| FROM ReferenceIndexEntity a | ||
| WHERE a.index_name = ? AND a.resourceUuid IN ( | ||
| SELECT resourceUuid FROM TokenIndexEntity | ||
| WHERE resourceType = ? AND index_name = ? AND (index_value = ? AND IFNULL(index_system,'') = ?) | ||
| UNION | ||
| SELECT resourceUuid FROM TokenIndexEntity | ||
| WHERE resourceType = ? AND index_name = ? AND (index_value = ? AND IFNULL(index_system,'') = ?) | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I think this won't perform as expected. The precedence of INTERSECTION is higher than UNION. Therefore, this query is interpreted as:
(Given: "John") UNION ( (Given: "Jane") INTERSECT (Condition: Diabetes OR Hypertension) )
This is not the intended logic. The test is trying to find Patients where:
( (Given: "John" OR Given: "Jane") AND (Condition: Diabetes OR Condition: Hypertens
There was a problem hiding this comment.
Can you confirm this? And make changes if needed ?
There was a problem hiding this comment.
Cool, will have a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2725
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.