Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply image using setImageBitmap #2650

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Apply image using setImageBitmap #2650

wants to merge 5 commits into from

Conversation

FikriMilano
Copy link
Collaborator

@FikriMilano FikriMilano commented Jul 29, 2024 •
edited
Loading

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2649

Description
Apply image using setImageBitmap

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Bug fix

Video

no_flicker.webm

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Jul 30, 2024
@ndegwamartin
SDK Release
20912f5 
    - With unmerged PR #9
    - WUP PR google#2178

- WUP google#2652
- WUP google#2521
- WUP google#2645
- WUP google#2648
- WUP google#2650
jingtang10
jingtang10 reviewed Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed during the developers call, pls check the use of glide in the attachment widget just so we're dealing with images consistently in different parts of the sdc lib.

thanks @FikriMilano!

ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Sep 4, 2024
@ndegwamartin
SDK Release - Engine, SDC, Knowledge, Workflow
9d2f6d1 
        - With unmerged PR #9
        - WUP PR google#2178
        - WUP google#2650
@ndegwamartin ndegwamartin requested a review from a team as a code owner September 4, 2024 17:15
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Sep 10, 2024
@ndegwamartin
SDK Release - Engine, SDC, Knowledge, Workflow
e1cf4c5 
FORK
         - With unmerged PR #9
            - WUP  #13

SDK
            - WUP google#2178
            - WUP google#2650
            - WUP google#2663
PERF
- WUP google#2669
- WUP google#2565
- WUP google#2561
- WUP google#2535
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Sep 10, 2024
@ndegwamartin
SDK Release - Engine, SDC, Knowledge, Workflow
dcc81ae 
            - With unmerged PR #9
            - WUP  #13

            - WUP google#2178
            - WUP google#2650
            - WUP google#2663
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Oct 2, 2024
@ndegwamartin
SDK Release - Engine, SDC, Knowledge, Workflow
10e24ef 
    FORK
             - With unmerged PR #9
                - WUP  #13

    SDK
                - WUP google#2178
                - WUP google#2650
                - WUP google#2663
    PERF
    - WUP google#2669
    - WUP google#2565
    - WUP google#2561
    - WUP google#2535
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Nov 4, 2024
@ndegwamartin
SDK Release - Engine, SDC, Workflow
0abb05d 
FORK
                - With unmerged PR #9
                - WUP  #13

SDK
                - WUP google#2178
                - WUP google#2650
                - WUP google#2663
                - WUP google#2689
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Nov 5, 2024
@ndegwamartin
SDK Release - Engine, SDC, Workflow
fbb0b0a 
    FORK
                    - With unmerged PR #9
                    - WUP  #13

    SDK
                    - WUP google#2178
                    - WUP google#2650
                    - WUP google#2663
                    - WUP google#2689
                    - WUP google#2645
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Nov 12, 2024
@ndegwamartin
SDK Release - SDC
c1abadb 
        FORK
                        - With unmerged PR #9
                        - WUP  #13

        SDK
                        - WUP google#2178
                        - WUP google#2650
                        - WUP google#2663
                        - WUP google#2645
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Nov 12, 2024
@ndegwamartin
SDK Release - SDC, Engine
cd4606b 
        FORK
                        - With unmerged PR #9
                        - WUP  #13

        SDK
                        - WUP google#2178
                        - WUP google#2650
                        - WUP google#2663
                        - WUP google#2645
                        - WUP google#2715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingtang10 jingtang10 jingtang10 left review comments

@aditya-07 aditya-07 Awaiting requested review from aditya-07

@MJ1998 MJ1998 Awaiting requested review from MJ1998

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

itemMediaView image flicker when loading image
3 participants
@FikriMilano @jingtang10 @ndegwamartin