This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 694
Add brightness control #291
Open
mpember
wants to merge
29
commits into
google:aiyprojects
Choose a base branch
from
mpember:aiyprojects
base: aiyprojects
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it!! |
CLAs look good, thanks! |
Is there a preferred method of checking the brightness variable is valid? I considered having it expect an integer between 0-100 and testing the range. From there, it would be divided by 100 and stored in the brightness variable. |
mpember
force-pushed
the
aiyprojects
branch
5 times, most recently
from
June 10, 2018 14:21
4030386
to
45a0600
Compare
A brightness variable make it possible to set a maximum LED brightness.
Update code to use 'in' to detect matches, where possible. Minor cleaning up.
Add optional allowance for 'turn on THE <switch>' in addition to 'turn on <switch>'
Podcast commands: + Add support for "play <podcast name> podcast" variation of command. * Resolve incorrect detection of empty feeds. * Resolve handling of "&" in podcast or episode name. Kodi commands: + Add "update tv shows" command to scan for new episodes. Power commands: * Improve command detection method MPD connection: * Handle timeout of MPD connection, when MPD is not used.
+ New 'podcatcher' service for caching podcast information. * Reduced service logging to 'warning' level. * Added CLI detection to maintain 'info' logging level for testing purposes.
Avoid redundant processing of existing podcast episodes.
Power commands are now sent to MQTT broker
Add ability to press button to stop podcast list action
mpember
force-pushed
the
aiyprojects
branch
2 times, most recently
from
August 12, 2018 15:27
de8b89e
to
1cf3d1e
Compare
Updates to voice commands, Kodi-related module and music-related modules.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brightness variable make it possible to set a maximum LED brightness.