Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Add brightness control #291

Open
wants to merge 29 commits into
base: aiyprojects
Choose a base branch
from
Open

Conversation

mpember
Copy link

@mpember mpember commented Mar 2, 2018

A brightness variable make it possible to set a maximum LED brightness.

@googlebot
Copy link

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@mpember
Copy link
Author

mpember commented Mar 2, 2018

I signed it!!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Mar 2, 2018
@mpember
Copy link
Author

mpember commented Mar 2, 2018

Is there a preferred method of checking the brightness variable is valid? I considered having it expect an integer between 0-100 and testing the range. From there, it would be divided by 100 and stored in the brightness variable.

@mpember mpember force-pushed the aiyprojects branch 5 times, most recently from 4030386 to 45a0600 Compare June 10, 2018 14:21
A brightness variable make it possible to set a maximum LED brightness.
Update code to use 'in' to detect matches, where possible.
Minor cleaning up.
Add optional allowance for 'turn on THE <switch>' in addition to 'turn on <switch>'
Podcast commands:
+ Add support for "play <podcast name> podcast" variation of command.
* Resolve incorrect detection of empty feeds.
* Resolve handling of "&" in podcast or episode name.

Kodi commands:
+ Add "update tv shows" command to scan for new episodes.

Power commands:
* Improve command detection method

MPD connection:
* Handle timeout of MPD connection, when MPD is not used.
mpember and others added 12 commits June 18, 2018 03:16
+ New 'podcatcher' service for caching podcast information.
* Reduced service logging to 'warning' level.
* Added CLI detection to maintain 'info' logging level for testing purposes.
Avoid redundant processing of existing podcast episodes.
Power commands are now sent to MQTT broker
Add ability to press button to stop podcast list action
@mpember mpember force-pushed the aiyprojects branch 2 times, most recently from de8b89e to 1cf3d1e Compare August 12, 2018 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants