Skip to content

site: redesign the landing page in a Google style - #921

Merged
aojea merged 1 commit into
google:mainfrom
baltej223:site/google-style-landing
Nov 20, 2026
Merged

aojea merged 1 commit into
google:mainfrom
baltej223:site/google-style-landing

Conversation

@baltej223

@baltej223 baltej223 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Rebuild site/layouts/index.html and its scoped styles in _styles_project.scss with Google Sans, the Google blue/red/yellow/green palette and Material-style pills, cards and tabs. The page follows the docs' td-color-theme setting (light, dark or system) and adds a theme toggle, an accessible tab list, a phone menu and a skip link. The request flow diagram is now responsive HTML with pulses along the data path, and the security section shows the Biscuit block structure. Docs pages and their styles are unchanged.

@baltej223
baltej223 requested a review from aojea as a code owner November 20, 2026 07:04
@google-cla

google-cla Bot commented Nov 20, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the custom dark-themed landing page with a Google-style landing page supporting both light and dark modes. This involves a complete rewrite of the SCSS styles and the HTML structure, introducing Google Sans fonts, Material 3-style components, a responsive layout, and interactive elements like a theme switcher and deployment tabs. Feedback on the changes highlights a security risk of piping curl directly to bash in the quickstart instructions, and an accessibility issue regarding the lack of captions (<track> elements) in the demo videos.

Comment thread site/layouts/index.html Outdated
</button>
</div>
<pre class="gm-code-body"><code><span class="c"># 1. Install agentmesh-one and agentmesh-node</span>
<span class="p">$</span> curl -sL https://google.github.io/agentmesh/install.sh | bash

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Piping curl directly to bash is a security risk because it executes unverified remote code. If the connection is hijacked or the server is compromised, malicious code can be executed on the user's machine. It is safer to download the script first, allow the user to inspect it, and then run it.

Suggested change
<span class="p">$</span> curl -sL https://google.github.io/agentmesh/install.sh | bash
<span class="p">$</span> curl -sSL https://google.github.io/agentmesh/install.sh -o install.sh && sh install.sh
References
  1. Piping curl directly to bash is a security risk as it executes unverified remote code. It is recommended to instruct users to download, inspect, and then run the script, or use a safer alternative.

Comment thread site/layouts/index.html
<div class="gm-grid-3">
<article class="gm-video">
<header><h3>Sandboxed agents with zero keys</h3><a href="{{ "docs/preview/sandboxed-agents/" | relURL }}">Read the guide<svg aria-hidden="true"><use href="#i-arrow"/></svg></a></header>
<video controls preload="metadata" src="{{ "demo-sandboxed-agent.mp4" | relURL }}" aria-label="Sandboxed agents demo"></video>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The <video> element lacks a <track> element for captions or subtitles. Providing captions is essential for accessibility (WCAG 1.2.2) to ensure deaf or hard-of-hearing users can access the audio content of the video walkthroughs. Please add a <track> element with captions for this video and the other videos on the page.

Suggested change
<video controls preload="metadata" src="{{ "demo-sandboxed-agent.mp4" | relURL }}" aria-label="Sandboxed agents demo"></video>
<video controls preload="metadata" src="{{ "demo-sandboxed-agent.mp4" | relURL }}" aria-label="Sandboxed agents demo">
<track kind="captions" src="{{ "demo-sandboxed-agent.vtt" | relURL }}" srclang="en" label="English" default>
</video>

@baltej223

Copy link
Copy Markdown
Contributor Author
image

@aojea

aojea commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

@baltej223 really nice, but we need the CLA to be signed to be able to merge

Replace the landing page and its scoped styles with a Material-style
design in the Google palette (blue, red, yellow, green) and Google Sans:
pills, cards and tabs over the existing content.

Follow the docs' td-color-theme setting (light, dark or system) and add
a theme toggle, an accessible tab list, a phone menu and a skip link.

Replace the static request-flow image with a responsive HTML diagram
whose data path pulses, and show the Biscuit block structure in the
security section. Docs pages and their styles are unchanged.

Stop piping install.sh into bash: download the installer, read it, then
run `bash install.sh`. install.sh uses bash features (set -o pipefail),
so it is run with bash, not sh. The Copy button copies the same lines.
@baltej223
baltej223 force-pushed the site/google-style-landing branch from c6c12f7 to 28359db Compare November 20, 2026 10:21
@baltej223

Copy link
Copy Markdown
Contributor Author

Done, Claude is no longer the co-author, CLA test passes.

@aojea
aojea merged commit 6c97ef5 into google:main Nov 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants