Feat/short movie agents agent starter pack

[maeve2024]

Agent Starter Pack:

pyproject.toml

• Added [tool.agent-starter-pack] with example_question and [tool.agent-starter-pack.settings] (agent_directory = "app").
• Added agent-starter-pack>=0.14.1 to the dev dependency group.
• app/agent.py
• Added flexible auth block: set GOOGLE_CLOUD_PROJECT, GOOGLE_CLOUD_LOCATION, and GOOGLE_GENAI_USE_VERTEXAI from google.auth.default() so the agent works in ASP-generated projects.

README.md

• Added a “Recommended: Using Agent Starter Pack” section before Requirements.
• Primary flow: uvx agent-starter-pack create my-short-movie-agents -a adk@short-movie-agents.
• Alternative pip/venv flow in a collapsible section.

Build & lint:

pyproject.toml

• [project.optional-dependencies] with a lint extra (codespell, ruff, mypy) so make lint works.
• [tool.codespell] with ignore-words-list = "rouge" to avoid false positives.

uv.lock

• Regenerated with uv lock (includes agent-starter-pack and its dependencies).

Lint/type fixes:

app/story_agent.py

• type: ignore[no-redef] on the fallback from adk.agents import Agent to satisfy mypy with the try/except import.

app/storyboard_agent.py

• Only include images with a non-None _gcs_uri in the returned list so the result type is consistent.

app/video_agent.py

• Guard on operation.result and use result.generated_videos or []; in the list comp, only include items where video.video and video.video.uri are set.

app/utils/gcs.py and app/utils/tracing.py

• type: ignore[attr-defined] on from google.cloud import storage where mypy cannot resolve the storage attribute.

Testing:

• Integration tests pass in an ASP-generated project; agent manually tested in ADK web UI (make playground).

Reverting: I was only supposed to approve the workflow runs, not the PR itself.

[zeroasterisk]

where is this change from? what is the uri variable? this smells like hallucination which wouldn't work

[zeroasterisk]

what is going on here?

[zeroasterisk]

Why not a copy/paste from the other PRs so they all share the same heading?
https://github.com/google/adk-samples/pull/1286/changes

[zeroasterisk]

ASP Integration Checklist (ref: PR #1286 as approved template)

• ✅ ASP section added to README
• ✅ Code cleanup (type: ignore, import fix)
• ⚠️ os.environ["GOOGLE_CLOUD_LOCATION"] = "global" is a hard override — should be os.environ.setdefault("GOOGLE_CLOUD_LOCATION", "global") like the other two vars. Hard assignment silently overwrites any user-configured value.
• ⚠️ README ASP section less structured than #1286 — Missing the "From your newly created project directory, run:" follow-up with uv sync --dev and uv run adk web instructions. Match #1286's pattern.
• ⚠️ Local dev fallback — Should follow the same <details><summary>Alternative: Local development</summary> structure as #1286.

Fix the setdefault and tighten the README to match the approved #1286 template.

[zeroasterisk]

Good progress — setdefault fixed, ASP as recommended with <details> collapse.

One thing: add the post-scaffold run instructions after the uvx command, like you did in #1286:

cd my-short-movie-agents
uv sync --dev
uv run adk run short_movie_agents

And for web UI:

uv run adk web

Small addition, then this matches the approved template.

[zeroasterisk]

The auth block (google.auth.default() + os.environ.setdefault(...)) should be in __init__.py, not in agent.py. The auth block needs to run at package import time, before any agent code references environment variables.

Please:

1. Move the auth block to __init__.py
2. Bump agent-starter-pack to >=0.32.0

See PR #1383 (ml-engineering) for the correct __init__.py pattern.

[zeroasterisk]

Changes look great, thank you! ✅

[zeroasterisk]

Changes look great, thank you! ✅

[zeroasterisk]

Changes look great, thank you! ✅

[zeroasterisk]

Changes look great, thank you! ✅