fix(core): improve clarity and actionable context in error messages - #6487
Open
Ahmed-Ali-313 wants to merge 1 commit into
Open
fix(core): improve clarity and actionable context in error messages#6487Ahmed-Ali-313 wants to merge 1 commit into
Ahmed-Ali-313 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem:
Several core error messages in
runners.py,llm_agent.py,llm_request.py, andllm_agent_config.pywere vague, missing the actual input values/types, or lacked guidance on how developers could fix the configuration issue.Solution:
Runner._resolve_appto output actual provided arguments/types.LlmAgent.set_default_modelandset_default_live_modelto reporttype(model).__name__.LlmAgent.validate_generate_content_configexplaining where to placetools,instruction,output_schema, andhttp_options.LlmRequest.append_instructionsand values inLlmAgentConfig._validate_model_sources.test_improved_error_messages.py.Testing Plan
Unit Tests:
tests/unittests/agents/test_improved_error_messages.py).Pytest Summary:
13 passed in 4.64sManual End-to-End (E2E) Tests:
Verified that triggering misconfigurations (e.g., passing invalid model types or duplicate Runner arguments) now prints rich, actionable error tracebacks.
Checklist