fix(sessions): honor zero recent events in database service#5965
Open
White-Mouse wants to merge 1 commit into
Open
fix(sessions): honor zero recent events in database service#5965White-Mouse wants to merge 1 commit into
White-Mouse wants to merge 1 commit into
Conversation
adk-bot
added
the
services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetSessionConfig(num_recent_events=0)inDatabaseSessionServicetest_get_session_with_configMotivation
GetSessionConfigdocumentsnum_recent_events=0as returning no events. InMemory and Sqlite already preserve that behavior, and ADK call sites usenum_recent_events=0when they only need to check whether a session exists.DatabaseSessionServiceused a truthy check, so0skipped the SQLLIMITand returned the full event history.Testing
uv run --extra test pytest tests/unittests/sessions/test_session_service.py::test_get_session_with_config -quv run --extra test pytest tests/unittests/sessions -quvx pyink --check src/google/adk/sessions/database_session_service.py tests/unittests/sessions/test_session_service.pyuv run python -m py_compile src/google/adk/sessions/database_session_service.py tests/unittests/sessions/test_session_service.pygit diff --check