Skip to content

fix: crashing while exiting loop agent in web #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: crashing while exiting loop agent in web #566

wants to merge 6 commits into from

Conversation

kavinkumar807
Copy link

This PR fixes #501

  • refactored the tracer.start_as_current_span with start_span to manually handle the context var detach
  • There was a issue where the event was not yielded on escalation, added fix for that too
  • There was a formatting issue src/google/adk/sessions/database_session_service.py fixed that too

Refs:

  1. opentelemetry.io
  2. cncf
  3. opentelemetry-python
  4. open-telemetry-issue-2787

@kavinkumar807 kavinkumar807 changed the title Crash while exiting loop agent in adk web fix: crashing while exiting loop agent in web May 5, 2025
@kavinkumar807
Copy link
Author

@hangfei @boyangsvl raised PR

@kavinkumar807
Copy link
Author

@hangfei @boyangsvl Synced the branch

@kavinkumar807
Copy link
Author

kavinkumar807 commented May 6, 2025 •
edited
Loading

@hangfei @boyangsvl Synced the PR with the main

@kavinkumar807
Copy link
Author

@hangfei @boyangsvl Synced the PR with the main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash while exiting loop agent in adk web
1 participant
@kavinkumar807