-
Notifications
You must be signed in to change notification settings - Fork 858
fix: Update skipped tests in test_auth_handlers #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@luaifei thanks for the fix. Could you update this file(https://github.com/google/adk-python/blob/main/.github/workflows/python-unit-tests.yml#L39) so it will be included in the workflow testing? |
Hi @hangfei Thanks for your review. I have already updated the tests workflow. I will take some time to fix the tests in |
Copybara import of the project: -- 93cc9c0 by luaifei <[email protected]>: fix: Update skipped tests in test_auth_handlers -- 06ddf55 by luaifei <[email protected]>: fix: Update skipped & failed tests in test_connections_client and test_streaming -- b8f2d35 by luaifei <[email protected]>: fix: Remove ignored test file from Python unit tests workflow COPYBARA_INTEGRATE_REVIEW=#553 from luaifei:fix-tests d51e428 PiperOrigin-RevId: 755669644
merged in d5b3a89 |
@luaifei seems the tests are still failing. Could you help take a look? |
Let me check @hangfei |
Hi @luaifei after checking, I see that the failed unit tests occur within a new file named |
I see. I misunderstood earlier. Thanks for fixing the new failed ones! |
No description provided.