Skip to content

fix: Update skipped tests in test_auth_handlers #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

luaifei
Copy link
Contributor

@luaifei luaifei commented May 4, 2025

No description provided.

Copy link

google-cla bot commented May 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hangfei
Copy link
Collaborator

hangfei commented May 5, 2025

@luaifei thanks for the fix. Could you update this file(https://github.com/google/adk-python/blob/main/.github/workflows/python-unit-tests.yml#L39) so it will be included in the workflow testing?

@hangfei hangfei requested review from hangfei and Jacksunwei May 5, 2025 02:55
@luaifei
Copy link
Contributor Author

luaifei commented May 5, 2025

Hi @hangfei Thanks for your review. I have already updated the tests workflow. I will take some time to fix the tests in test_artifact_service.py and test_googleapi_to_openapi_converter.py when I am free.

@hangfei hangfei added the ready to pull for importing back to Google label May 7, 2025
copybara-service bot pushed a commit that referenced this pull request May 7, 2025
Copybara import of the project:

--
93cc9c0 by luaifei <[email protected]>:

fix: Update skipped tests in test_auth_handlers

--
06ddf55 by luaifei <[email protected]>:

fix: Update skipped & failed tests in test_connections_client and test_streaming

--
b8f2d35 by luaifei <[email protected]>:

fix: Remove ignored test file from Python unit tests workflow
COPYBARA_INTEGRATE_REVIEW=#553 from luaifei:fix-tests d51e428
PiperOrigin-RevId: 755669644
@hangfei
Copy link
Collaborator

hangfei commented May 7, 2025

merged in d5b3a89

@hangfei hangfei closed this May 7, 2025
@hangfei
Copy link
Collaborator

hangfei commented May 7, 2025

@luaifei seems the tests are still failing. Could you help take a look?

@luaifei
Copy link
Contributor Author

luaifei commented May 8, 2025

Let me check @hangfei

@luaifei
Copy link
Contributor Author

luaifei commented May 8, 2025

Hi @luaifei after checking, I see that the failed unit tests occur within a new file named tools/application_integration_tool/clients/test_integration_client.py, I will fix it with a new pull-request. Is it okay?

@luaifei
Copy link
Contributor Author

luaifei commented May 8, 2025

Hi @hangfei I have already fixed the failed unit tests and create one new pull request. Here is the link: #617
Please help review it. Thanks

@hangfei
Copy link
Collaborator

hangfei commented May 8, 2025

I see. I misunderstood earlier. Thanks for fixing the new failed ones!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull for importing back to Google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants