fix: Some tools in LLM requests are missing the description#552
Closed
efunneko wants to merge 11 commits intogoogle:mainfrom
Closed
fix: Some tools in LLM requests are missing the description#552efunneko wants to merge 11 commits intogoogle:mainfrom
efunneko wants to merge 11 commits intogoogle:mainfrom
Conversation
Collaborator
|
@efunneko thanks for the fix. Could you provide before vs after fix logs/screenshots? |
|
I'm seeing this issue as well using claude 3.7 sonnet in Bedrock through litellm. Without the fix, I get Bedrock exceptions stating that the description field is missing. When I apply the fix, the exceptions go away. Here is an example exception: |
Contributor
Author
|
@hangfei - I saw the exact same logs as what @gregmeldrum posted in his comment above. The logs went away after the fix was made. Please let me know if you would still like screen shots from a debug session or if this is enough |
Contributor
Author
|
@hangfei Please let me know if you still need more from me on this. The fix is very straightforward and makes a big difference to system performance. |
seanzhou1023
approved these changes
May 31, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
May 31, 2025
Copybara import of the project: -- 8540f26 by Edward Funnekotter (aider) <efunneko@gmail.com>: fix: ensure function description is copied when ignoring parameters -- b9fb591 by Edward Funnekotter <efunneko@gmail.com>: Fix annoying comments COPYBARA_INTEGRATE_REVIEW=#552 from efunneko:efunneko/122/copy_doc_string_for_tool d9bc243 PiperOrigin-RevId: 765470363
Collaborator
|
merged in 7fdc6b4 |
whhlct
pushed a commit
to whhlct/adk-python
that referenced
this pull request
Jun 6, 2025
Copybara import of the project: -- 8540f26 by Edward Funnekotter (aider) <efunneko@gmail.com>: fix: ensure function description is copied when ignoring parameters -- b9fb591 by Edward Funnekotter <efunneko@gmail.com>: Fix annoying comments COPYBARA_INTEGRATE_REVIEW=google#552 from efunneko:efunneko/122/copy_doc_string_for_tool d9bc243 PiperOrigin-RevId: 765470363
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
Copybara import of the project: -- 8540f26 by Edward Funnekotter (aider) <efunneko@gmail.com>: fix: ensure function description is copied when ignoring parameters -- b9fb591 by Edward Funnekotter <efunneko@gmail.com>: Fix annoying comments COPYBARA_INTEGRATE_REVIEW=google#552 from efunneko:efunneko/122/copy_doc_string_for_tool d9bc243 PiperOrigin-RevId: 765470363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #551
This fix will copy over the original function's doc string for functions that have ignored parameters.