Skip to content

fix: support path level parameters for open_api_spec_parser #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jeffreyrubi
Copy link

@jeffreyrubi jeffreyrubi commented May 4, 2025

Adding support of path level parameters in open_api_spec_parser as defined in the OpenAPI spec.
Ref: https://swagger.io/docs/specification/v3_0/describing-parameters/#common-parameters

This PR aimed in fixing #540 (*detailed problem description)

What this PR does

  • Append path-level parameters to all HTTP methods under the path operator as defined in OpenAPI spec.
  • Unittest to ensure it works as expected.

Proof that it works


expected

Copy link

google-cla bot commented May 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jeffreyrubi jeffreyrubi force-pushed the fix/missing-path-level-parameters branch 5 times, most recently from 48b969b to 777a292 Compare May 4, 2025 09:25
@jeffreyrubi jeffreyrubi force-pushed the fix/missing-path-level-parameters branch from 777a292 to 34b0012 Compare May 4, 2025 12:50
@jeffreyrubi jeffreyrubi changed the title fix#540 support path level parameters for open_api_spec_parser fix: support path level parameters for open_api_spec_parser May 4, 2025
@hangfei hangfei requested a review from seanzhou1023 May 5, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant