fix: nested loop agents escalation issue #535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nested loop agents scenario, the event.action.escalate will break all loop agents, the expected behavior should be only break one level of the loop agents.
Fix nested loop agents escalation issue
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
nx90
changed the title
Jacksunwei
approved these changes
May 5, 2025
|
Actually I think the action should not be changed. We should check whether there is no another loop agent between the current agent and the event author. |
Jacksunwei
reviewed
May 5, 2025
| if event.actions.escalate: | ||
| # Reset the escalate status to make sure this escalation only exits one level of the loop agent, not the entire nested loop agents structure. | ||
| event.actions.escalate = False |
There was a problem hiding this comment.
We should instead check whether this is no more loop agent between this agent and the event author agent.
event.actions.escalate is the conversation history and we shouldn't alter it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nested loop agents scenario, the event.action.escalate will break all loop agents, the expected behavior should be only break one level of the loop agents.
Issue link: #526