-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: nested loop agents escalation issue #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In nested loop agents scenario, the event.action.escalate will break all loop agents, the expected behavior should be only break one level of the loop agents.
Fix nested loop agents escalation issue
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Actually I think the action should not be changed. We should check whether there is no another loop agent between the current agent and the event author. |
| yield event | ||
| if event.actions.escalate: | ||
| # Reset the escalate status to make sure this escalation only exits one level of the loop agent, not the entire nested loop agents structure. | ||
| event.actions.escalate = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should instead check whether this is no more loop agent between this agent and the event author agent.
event.actions.escalate is the conversation history and we shouldn't alter it.
|
@selcukgun could you take over and finish this PR? |
|
Hi @nx90 and thanks to everyone who participated in this thread. We're currently doing some housekeeping on our pull request queue. Given the rapid pace of development and the number of updates since this was last active, there's a good chance this pull request needs to be caught up to the latest version. To help us keep our backlog focused on current pull requests, we are closing this as stale. If you're still interested in contributing to this change, could you please update to the very latest version of the library and create a new pull request? Our team will be glad to help with the refreshed PRs and answer any questions! Thanks for your contribution and understanding! |
In nested loop agents scenario, the event.action.escalate will break all loop agents, the expected behavior should be only break one level of the loop agents.
Issue link: #526