Skip to content

Conversation

@nx90
Copy link

@nx90 nx90 commented May 3, 2025

In nested loop agents scenario, the event.action.escalate will break all loop agents, the expected behavior should be only break one level of the loop agents.

Issue link: #526

nx90 added 2 commits May 3, 2025 23:05
In nested loop agents scenario, the event.action.escalate will break all loop agents, the expected behavior should be only break one level of the loop agents.
Fix nested loop agents escalation issue
@google-cla
Copy link

google-cla bot commented May 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nx90 nx90 changed the title Fix nested loop agents escalation issue fix: nested loop agents escalation issue May 3, 2025
@Jacksunwei Jacksunwei added the ready to pull [Status] This PR is ready to be importing back to Google label May 5, 2025
@Jacksunwei Jacksunwei self-assigned this May 5, 2025
@Jacksunwei Jacksunwei removed the ready to pull [Status] This PR is ready to be importing back to Google label May 5, 2025
@Jacksunwei
Copy link
Collaborator

Actually I think the action should not be changed. We should check whether there is no another loop agent between the current agent and the event author.

@Jacksunwei Jacksunwei self-requested a review May 5, 2025 07:47
yield event
if event.actions.escalate:
# Reset the escalate status to make sure this escalation only exits one level of the loop agent, not the entire nested loop agents structure.
event.actions.escalate = False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should instead check whether this is no more loop agent between this agent and the event author agent.


event.actions.escalate is the conversation history and we shouldn't alter it.

@Jacksunwei Jacksunwei assigned selcukgun and unassigned Jacksunwei May 21, 2025
@Jacksunwei
Copy link
Collaborator

@selcukgun could you take over and finish this PR?

@ryanaiagent ryanaiagent self-assigned this Oct 3, 2025
@ryanaiagent
Copy link
Collaborator

Hi @nx90 and thanks to everyone who participated in this thread.

We're currently doing some housekeeping on our pull request queue. Given the rapid pace of development and the number of updates since this was last active, there's a good chance this pull request needs to be caught up to the latest version. To help us keep our backlog focused on current pull requests, we are closing this as stale.

If you're still interested in contributing to this change, could you please update to the very latest version of the library and create a new pull request? Our team will be glad to help with the refreshed PRs and answer any questions!

Thanks for your contribution and understanding!

@ryanaiagent ryanaiagent closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants