-
Notifications
You must be signed in to change notification settings - Fork 845
fix: added build and local testing command #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kavinkumar807
wants to merge
14
commits into
google:main
Choose a base branch
from
kavinkumar807:fix-readme-pip-install
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r807/adk-python into fix-readme-pip-install
@hangfei @boyangsvl Raised PR |
@hangfei @boyangsvl I see the pip install issue is fixed as part of #520. Therefore repurposing this PR for the lint changes and other readme updates. |
I'm not sure why test cases are failing for readme changes |
@hangfei @boyangsvl Synced with latest changes |
@hangfei @boyangsvl Synced the branch |
hangfei
reviewed
May 6, 2025
hangfei
reviewed
May 6, 2025
@hangfei resolved and synced with changes with main |
@hangfei Synced the PR with main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #564