Skip to content

Fixes issue #4890#4903

Open
noah082011 wants to merge 2 commits intogoogle:mainfrom
noah082011:Fix-Issue-#4890
Open

Fixes issue #4890#4903
noah082011 wants to merge 2 commits intogoogle:mainfrom
noah082011:Fix-Issue-#4890

Conversation

@noah082011
Copy link

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):
#4890

2. Or, if no issue exists, describe the change:

Problem:
When initializing the DatabaseSessionService, the log message used the phrase "Falling back to...", which implies a failure or an unintended state. This caused confusion during debugging when a database URI was intentionally provided.

Solution:
Updated the log message in service_factory.py to say "Using DatabaseSessionService..." to accurately reflect that the service is being initialized as intended.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.
All unit tests for service_factory.py pass locally
Manual End-to-End (E2E) Tests:

Initialize the ADK CLI using a metadata database URI
The log should now display INFO - Using DatabaseSessionService... instead of the previous "Falling back to..." message.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@adk-bot adk-bot added the services [Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc label Mar 19, 2026
@rohityan rohityan self-assigned this Mar 20, 2026
@rohityan rohityan added the needs review [Status] The PR/issue is awaiting review from the maintainer label Mar 20, 2026
@rohityan
Copy link
Collaborator

Hi @noah082011 , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

@rohityan
Copy link
Collaborator

Hi @Jacksunwei , can you please review this. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review [Status] The PR/issue is awaiting review from the maintainer services [Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading 'Falling back to DatabaseSessionService' log for PostgreSQL URIs

3 participants