Skip to content

Conversation

@Edge-Seven
Copy link

Contribution by Gittensor, learn more at https://gittensor.io/

@google-cla
Copy link

google-cla bot commented Nov 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Edge-Seven, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code quality and readability by addressing several minor typographical errors across various files. The changes are purely cosmetic, ensuring consistency and correctness in comments, docstrings, and string literals, without altering any functional logic.

Highlights

  • Typo Fix in adk_web_server.py: Corrected 'reenable' to 're-enable' in a TODO comment related to metrics.
  • Typo Fix in connections_client.py: Changed 'incase' to 'in case' within a description string for a host name.
  • Typo Fix in test_response_evaluator.py: Updated a test function's docstring, correcting 'Rouge metric' to 'Rogue metric'.
  • Typo Fix in test_litellm.py: Corrected 'Licens' to 'License' in the file's license header comment.
  • Typo Fix in test_bigquery_query_tool.py: Fixed 'successfull' to 'successful' in a test comment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the documentation [Component] This issue is related to documentation, it will be transferred to adk-docs label Nov 15, 2025
@adk-bot
Copy link
Collaborator

adk-bot commented Nov 15, 2025

Response from ADK Triaging Agent

Hello @Edge-Seven, thank you for your contribution!

It looks like the Contributor License Agreement (CLA) check has failed. Before we can merge this pull request, you'll need to sign the CLA. You can find more information and sign the agreement here: https://cla.developers.google.com/

Thank you!

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix typos across several files. While most of the fixes are correct, one change incorrectly alters 'Rouge' to 'Rogue' in a test file, which is a factual error for the ROUGE evaluation metric. Additionally, in another file, a line with two typos was only partially corrected, leaving one typo behind. I've provided suggestions to address both of these issues.


def test_evaluate_invocations_rouge_metric(self, mocker):
"""Test evaluate_invocations function for Rouge metric."""
"""Test evaluate_invocations function for Rogue metric."""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change appears to introduce an error. The metric is 'ROUGE' (Recall-Oriented Understudy for Gisting Evaluation), not 'Rogue'. The original 'Rouge' was correct. Please revert this change.

Suggested change
"""Test evaluate_invocations function for Rogue metric."""
"""Test evaluate_invocations function for Rouge metric."""

result = tool_call(settings, tool_context)

# Test successfull executeion of the tool
# Test successful executeion of the tool

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you've corrected 'successfull' to 'successful', there's another typo in this line. 'executeion' should be 'execution'.

Suggested change
# Test successful executeion of the tool
# Test successful execution of the tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation [Component] This issue is related to documentation, it will be transferred to adk-docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants