-
Notifications
You must be signed in to change notification settings - Fork 2.4k
docs: fix typos in some files #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @Edge-Seven, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving code quality and readability by addressing several minor typographical errors across various files. The changes are purely cosmetic, ensuring consistency and correctness in comments, docstrings, and string literals, without altering any functional logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @Edge-Seven, thank you for your contribution! It looks like the Contributor License Agreement (CLA) check has failed. Before we can merge this pull request, you'll need to sign the CLA. You can find more information and sign the agreement here: https://cla.developers.google.com/ Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix typos across several files. While most of the fixes are correct, one change incorrectly alters 'Rouge' to 'Rogue' in a test file, which is a factual error for the ROUGE evaluation metric. Additionally, in another file, a line with two typos was only partially corrected, leaving one typo behind. I've provided suggestions to address both of these issues.
|
|
||
| def test_evaluate_invocations_rouge_metric(self, mocker): | ||
| """Test evaluate_invocations function for Rouge metric.""" | ||
| """Test evaluate_invocations function for Rogue metric.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears to introduce an error. The metric is 'ROUGE' (Recall-Oriented Understudy for Gisting Evaluation), not 'Rogue'. The original 'Rouge' was correct. Please revert this change.
| """Test evaluate_invocations function for Rogue metric.""" | |
| """Test evaluate_invocations function for Rouge metric.""" |
| result = tool_call(settings, tool_context) | ||
|
|
||
| # Test successfull executeion of the tool | ||
| # Test successful executeion of the tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contribution by Gittensor, learn more at https://gittensor.io/