Fix: Correct message part ordering in A2A history #3262
+64
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Response from ADK Triaging Agent Hello @eranco74, thank you for creating this PR! Before we can proceed with the review, could you please address the following points from our contribution guidelines:
This information is necessary to ensure the quality and maintainability of the project. Thanks! |
eranco74
force-pushed
the
fix_message_parts_order
branch
from
8e8f7ef to
626425c
Compare
|
Unit tests: |
adk-bot
added
the
core
|
Response from ADK Triaging Agent Hello @eranco74, thank you for the update and for providing the unit test results! Before we can proceed with a full review, could you please address the remaining items from our contribution guidelines?
You can find more details in our CONTRIBUTING.md. Thanks for your contribution! |
eranco74
force-pushed
the
fix_message_parts_order
branch
from
626425c to
0578d43
Compare
The overall logic processes events in reverse chronological order and then reverses the entire list of collected parts at the end to restore the correct sequence of messages. However, the parts *within* a single message were being appended in their original forward order. This resulted in their sequence being incorrectly inverted by the final list reversal. This change fixes the issue by iterating over an event's parts in reverse. This pre-reversal ensures that after the final list-wide reversal, the internal order of parts within each message is correctly maintained. Signed-off-by: Eran Cohen <[email protected]>
eranco74
force-pushed
the
fix_message_parts_order
branch
from
0578d43 to
a7f01bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
The previous logic iterated through session events in reverse and then reversed the resulting list of parts. This caused incorrect ordering for multi-part messages generated by
_present_other_agent_message.Specifically, introductory text like "For context:" was appearing after the content it was meant to introduce.
This change simplifies the implementation by removing both reversals. It now processes events in chronological order, ensuring all message parts are appended in the correct sequence.
Please ensure you have read the contribution guide before creating a pull request.
Problem:
Incorrect ordering for multi-part messages generated by
_present_other_agent_message.Solution:
processes events in chronological order, ensuring all message parts are appended in the correct sequence.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context