Skip to content

chore: updating CONTRIBUTING.md with missing extra #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jackwotherspoon
Copy link
Contributor

@jackwotherspoon jackwotherspoon commented Jun 26, 2025

Contributing doc says to do the following:

uv sync --extra test --extra eval
pytest ./tests/unittests

If you follow this the tests will fail:

tests/unittests/a2a/executor/test_task_result_aggregator.py:27: in <module>
    from a2a.types import Message
E   ModuleNotFoundError: No module named 'a2a'

This makes sense since the a2a package is not part of ADK's core dep, it is an extra:

a2a = [
# go/keep-sorted start
"a2a-sdk>=0.2.7;python_version>='3.10'"
# go/keep-sorted end
]

Thus for a2a tests to pass we must include the extra in the sync command:

uv sync --extra test --extra eval --extra a2a
pytest ./tests/unittests

@jackwotherspoon
Copy link
Contributor Author

@seanzhou1023 mind giving this a stamp? 😄

@wuliang229 wuliang229 self-requested a review June 26, 2025 21:00
@wuliang229 wuliang229 added the ready to pull for importing back to Google label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull for importing back to Google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants