-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: raise ValueError when sessionId and userId are incorrect combination(#1653) #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…tion google#1653
Loading status checks…
DeanChensj
approved these changes
Jun 26, 2025
Loading status checks…
Loading status checks…
DeanChensj
approved these changes
Jun 26, 2025
Could you also run the auto formatter to resolve the pylink issue? |
Loading status checks…
wait a moment. |
@DeanChensj I've finished lint fix. |
DeanChensj
approved these changes
Jun 26, 2025
Waiting for approval from another team member |
Loading status checks…
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
Loading
Loading status checks…
This PR has been merged in 4e765ae |
rcleveng
pushed a commit
to rcleveng/adk-python
that referenced
this pull request
Jun 28, 2025
…tion(google#1653) Merge google#1655 Fix google#1653 When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session. COPYBARA_INTEGRATE_REVIEW=google#1655 from soundTricker:fix/1653-invalid-session 7a3dee2 PiperOrigin-RevId: 776648361
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
…tion(google#1653) Merge google#1655 Fix google#1653 When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session. COPYBARA_INTEGRATE_REVIEW=google#1655 from soundTricker:fix/1653-invalid-session 7a3dee2 PiperOrigin-RevId: 776648361
seanzhou1023
pushed a commit
to soundTricker/adk-python
that referenced
this pull request
Jul 11, 2025
…tion(google#1653) Merge google#1655 Fix google#1653 When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session. COPYBARA_INTEGRATE_REVIEW=google#1655 from soundTricker:fix/1653-invalid-session 7a3dee2 PiperOrigin-RevId: 776648361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1653
When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session.