Skip to content

fix: raise ValueError when sessionId and userId are incorrect combination(#1653) #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

soundTricker
Copy link
Contributor

Fix #1653

When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session.

…tion google#1653
@DeanChensj
Copy link
Collaborator

Could you also run the auto formatter to resolve the pylink issue?

@soundTricker
Copy link
Contributor Author

wait a moment.

@soundTricker
Copy link
Contributor Author

@DeanChensj I've finished lint fix.

@soundTricker soundTricker requested a review from DeanChensj June 26, 2025 04:38
@DeanChensj DeanChensj added the ready to pull [Status] This PR is ready to be importing back to Google label Jun 26, 2025
@DeanChensj
Copy link
Collaborator

Waiting for approval from another team member

copybara-service bot pushed a commit that referenced this pull request Jun 27, 2025
…tion(#1653)

Merge #1655

Fix #1653

When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session.

COPYBARA_INTEGRATE_REVIEW=#1655 from soundTricker:fix/1653-invalid-session 7a3dee2
PiperOrigin-RevId: 776648361
@DeanChensj
Copy link
Collaborator

This PR has been merged in 4e765ae

@DeanChensj DeanChensj closed this Jun 27, 2025
rcleveng pushed a commit to rcleveng/adk-python that referenced this pull request Jun 28, 2025
…tion(google#1653)

Merge google#1655

Fix google#1653

When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session.

COPYBARA_INTEGRATE_REVIEW=google#1655 from soundTricker:fix/1653-invalid-session 7a3dee2
PiperOrigin-RevId: 776648361
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
…tion(google#1653)

Merge google#1655

Fix google#1653

When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session.

COPYBARA_INTEGRATE_REVIEW=google#1655 from soundTricker:fix/1653-invalid-session 7a3dee2
PiperOrigin-RevId: 776648361
seanzhou1023 pushed a commit to soundTricker/adk-python that referenced this pull request Jul 11, 2025
…tion(google#1653)

Merge google#1655

Fix google#1653

When session_id and user_id are incorrect combination on vertex ai session service, it should not return the session.

COPYBARA_INTEGRATE_REVIEW=google#1655 from soundTricker:fix/1653-invalid-session 7a3dee2
PiperOrigin-RevId: 776648361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull [Status] This PR is ready to be importing back to Google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Issue] VertexAiSessionService return a invalid session when user_id is not correct.
2 participants