Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trace for PyTorch backend #914

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

merajhashemi
Copy link

Currently, the trace operator for PyTorch only supports up to 25-dimensional inputs due to using einsum. This PR fixes this issue.

@google-cla
Copy link

google-cla bot commented Mar 25, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 25, 2021
@merajhashemi
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 25, 2021
@mganahl
Copy link
Collaborator

mganahl commented Mar 26, 2021

@merajhashemi thanks for the PR. Looks good from my side. The build error is some flaky in the jax-backend. Let me first fix this test and we'll merge this in then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants