Skip to content

fix(ci): tsc build for package/core is idempodent #12112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

fix(ci): tsc build for package/core is idempodent #12112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"composite": true,
"types": ["node", "vitest/globals"]
},
"include": ["index.ts", "src/**/*.ts", "src/**/*.d.ts", "src/**/*.json"],
"include": ["index.ts", "src/**/*.ts", "src/**/*.json"],
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Removing src/**/*.d.ts from include may cause build failures if any manually-created ambient declaration files exist within the src directory. TypeScript will no longer automatically include these files, which can break type resolution for global augmentations or modules that are not explicitly imported (e.g., for assets like CSS/images or untyped dependencies), resulting in errors like TS2307: Cannot find module '...'.

While this change likely fixes the idempotency issue, a more robust long-term solution is to isolate necessary ambient declarations. Consider moving any such .d.ts files to a dedicated top-level types directory and including it via the typeRoots compiler option. This makes their global nature explicit and avoids potential conflicts with source files.

Copy link
Collaborator Author

@mattKorwel mattKorwel Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cornmander this is likely relevant to the changes you were tryign to make originally in #11157

Copy link
Collaborator

@cornmander cornmander Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, the tsignore at

gemini-cli/packages/core/src/utils/shell-utils.ts

Line 79 in 2dfb813

// @ts-ignore resolved by esbuild-plugin-wasm during bundling
makes this work even w/o the type file.

"exclude": ["node_modules", "dist"]
}