-
Notifications
You must be signed in to change notification settings - Fork 9.4k
refactor: move web_fetch tool name to tool-names.ts
#11174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving code maintainability and consistency by centralizing the definition of the 'web_fetch' tool name. By replacing a hardcoded string with an exported constant, it ensures that all references to this tool name are consistent and easily manageable from a single source, reducing the risk of typos and simplifying future updates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully refactors the hardcoded 'web_fetch' tool name into a centralized constant, WEB_FETCH_TOOL_NAME. The changes are applied consistently across the tool implementation, policy configuration, and related tests. This is a good practice that improves maintainability by eliminating magic strings. The implementation is correct and I have no issues to report.
|
Size Change: +141 B (0%) Total Size: 17.8 MB ℹ️ View Unchanged
|
TLDR
This PR moves the hardcoded
'web_fetch'string used for the Web Fetch tool name into the centralizedpackages/core/src/tools/tool-names.tsfile asWEB_FETCH_TOOL_NAME. It updates the tool implementation, policy configuration, and tests to use this exported constant.This should be a no-op
Reviewer Test Plan
This is a refactor with no functional changes. Verification relies on the build and test suite.
npm run buildto verify there are no TypeScript errors related to imports or variable usage.npm run testto ensure all tests pass, specificallypackages/cli/src/config/policy.test.tswhich was modified.npm run preflightfor a comprehensive check.Testing Matrix