Skip to content

fix(cli): Do not refresh pending settings after setting a setting. #11167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(cli): Do not refresh pending settings after setting a setting. #11167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2c404b
fix(cli): Do not refresh pending settings on reset
galz10 Oct 14, 2025
dd0bcd8
Merge branch 'main' into galzahavi/fix/setting-enable-bug
galz10 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/cli/src/ui/components/SettingsDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,6 @@ export function SettingsDialog({
next.delete(key);
return next;
});

// Refresh pending settings from the saved state
setPendingSettings(
structuredClone(settings.forScope(selectedScope).settings),
);
Copy link
Collaborator

@jacob314 jacob314 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add a test so we don't regress this. allowing users to be confident that their settings aren't corrupted is crucial.

} else {
// For restart-required settings, track as modified
setModifiedSettings((prev) => {
Expand Down