Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify AIS template #303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify AIS template #303

wants to merge 1 commit into from

Conversation

MarkDaoust
Copy link
Contributor

@MarkDaoust MarkDaoust commented Oct 7, 2024 •
edited
Loading

This is about the simplest I can make it. The many ways that AIS may send a file are the source of some of the complexity. A "no-files" version could simplify things a lot.

We loose three things if we do that:

  1. There's no "chat" (but we could split chat to it's own template).
  2. It's harder for users to tell what went wrong if something breaks.
  3. I removed the "show the conversation" code.
    • It's nice that it lets the user see what they're sending.
    • But it is long/complex.

WDYT?

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logankilpatrick logankilpatrick Awaiting requested review from logankilpatrick

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkDaoust