Refactor plotruns_lib in preparation for plotting extensions. #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_682055943
branch
2 times, most recently
from
248b7b6
to
822fb54
Compare
copybara-service
bot
force-pushed
the
test_682055943
branch
from
822fb54
to
5316b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor plotruns_lib in preparation for plotting extensions.
Streamline plotruns_lib for more abstraction. Specify data and formatting details in new PLOT_CONFIG object, which can be extended without needing to touch lib methods.
Remove redundant post_init for PlotData
Various cleanups, e.g.
(i) cleaner figure title handling
(ii) in comparison plots, the max and min are taken from the combined plots, as opposed to only the first dataset provided
(iii) attempt to set a better default ymax for the volatile chi plots
Correctness verified by eye through direct comparison with the legacy version.