Add support for specifying interpolation modes for time and rho_norm when loading InterpolatedVarTimeRho objects. #422
+247
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
theo-brown
reviewed
Sep 30, 2024
| @@ -392,3 +397,10 @@ def get_value(self, x: chex.Numeric) -> chex.Array: | |||
| TimeInterpolatedInput = ( | |||
| InterpolatedVarSingleAxisInput | tuple[InterpolatedVarSingleAxisInput, str] | |||
| ) | |||
| # Type-alias for a variable to be interpolated in time and rho_norm. | |||
There was a problem hiding this comment.
With the addition of TimeRhoInterpolatedInput, I think I'm happy with the naming we were discussing on the other commit!
copybara-service
bot
force-pushed
the
test_679547819
branch
2 times, most recently
from
7c52c6e
to
2aa77a8
Compare
…when loading InterpolatedVarTimeRho objects. Drive-by: - remove commented out branch in config parsing. - tidy up time rho interpolated tests into single parametrized test. PiperOrigin-RevId: 683181662
copybara-service
bot
force-pushed
the
test_679547819
branch
from
2aa77a8
to
2280c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying interpolation modes for time and rho_norm when loading InterpolatedVarTimeRho objects.
Drive-by: