change rbc sense to behave like APL's sense rules #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @acxz, Thanks for the PR. There were compilation errors when trying to run the test. Can you take a look? |
acxz
force-pushed
the
rbc-sense
branch
3 times, most recently
from
25032e7
to
dd83063
Compare
|
I'm afraid I do not know why the test is failing, @michalsustr when you get the chance would appreciate you taking a look. |
|
@acxz just checking in to see if you plan to continue working on this? If so, could I ask you to pull from master and push the merge commit to retrigger an invocation of the tests? The old one from April has been deleted. |
|
Sure thing |
|
Closing for now, please feel free to re-open if you continue working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address 1) of #811
@michalsustr