Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS support #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

macOS support #76

wants to merge 1 commit into from

Conversation

didzis
Copy link

@didzis didzis commented Nov 3, 2017

Adds macOS support remaining compatible with other platforms, i.e., intended to be merged with master branch. Works for all three modes: non-headless, headless with hardware acceleration and headless with software rendering. Build instructions found in docs/build_macos.md. This addresses #7, #39 and possibly #22.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

@@ -42,6 +44,44 @@
#error Must define DMLAB_SO_LOCATION dynamic library path.
#endif

#ifdef __APPLE__
ssize_t sendfile(int out_fd, int in_fd, off_t *offset, size_t count)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sendfile is available on BSD/MacOSX as well, e.g. https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/sendfile.2.html. It might have a slightly different signature than on Linux, but we shouldn't need to reimplement it.

@tkoeppe
Copy link
Collaborator

tkoeppe commented Oct 18, 2018

Hi! Are you still interested in this? I've put together a few smaller changes in the macos branch of this repository. At the top of that branch there's a commit that adds your new headless renderer, but that doesn't quite seem to work yet. If you like, feel free to send patches against that branch (e.g. by rebasing this pull request branch). I think all we need to do is fix up headless_macos_glimp.c.

tkoeppe added a commit that referenced this pull request Jan 14, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jan 14, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jan 14, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jan 14, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jan 14, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jan 14, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jan 15, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jul 22, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jul 22, 2021
Inspired by pull request #76, thank you!
tkoeppe added a commit that referenced this pull request Jul 22, 2021
Inspired by pull request #76, thank you!
@tkoeppe tkoeppe mentioned this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants