Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Lean 4.8.0 #2

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Update to Lean 4.8.0 #2

merged 4 commits into from
Aug 16, 2024

Conversation

girving
Copy link
Contributor

@girving girving commented Jun 6, 2024

No description provided.

@eric-wieser
Copy link
Collaborator

Please can you resolve the conflicts? Feel free to take your resolutions over the ones I introduced with the 4.7.0 update.

@eric-wieser
Copy link
Collaborator

Nevermind, I did the merge for you keeping all your changes. Please take a look over the result, and clean up any diffs that no longer makes sense.

Also, I think it would make more sense to bump to 4.8.0 (rather than the rc), or skip straight to 4.10.0

@girving
Copy link
Contributor Author

girving commented Aug 14, 2024

I also already did the merge, just haven’t pushed yet.

@girving
Copy link
Contributor Author

girving commented Aug 14, 2024

Would you be okay pausing on further detail changes? I’m a bit worried I have to redo all of my merge now.

@girving
Copy link
Contributor Author

girving commented Aug 14, 2024

I have a lot of downstream changes as well.

@girving
Copy link
Contributor Author

girving commented Aug 14, 2024

Actually let's hold off on the 4.10 upgrade, since I have a few more PRs to get in after this, and merging them prior to the upgrade will be easier.

@girving
Copy link
Contributor Author

girving commented Aug 14, 2024

On v4.8.0 exactly now, rather than -rc2.

@eric-wieser eric-wieser changed the title Update to Lean 4.8 Update to Lean 4.8.0 Aug 16, 2024
@eric-wieser eric-wieser merged commit 7fb3925 into google-deepmind:main Aug 16, 2024
2 checks passed
@girving girving deleted the lean-4.8 branch August 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants