Move async interaction from Coordinator to BaseSimulator.
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_684273378
branch
3 times, most recently
from
efeac5e
to
0c5b733
Compare
This change adds asynchronous interaction to all simulators (i.e. derived classes of `BaseSimulator`), making this type of interaction less specific about our specific usage in the `Coordinator`. This is an ongoing effort to separate the RL parts in AndroidEnv (mostly `AndroidEnv` and `TaskManager`) from the more generic parts like `BaseSimulator`. The interface of *derived* classes changed a little: instead of implementing `get_screenshot()` they now have to implement `_get_screenshot_impl()`. This change also contains a small fix to `BaseSimulator.__init__()` which instead of taking individual params, it now takes a single `SimulatorConfig`, making its initialization the same as other major components. This requires a small change to the `super().__init__()` call in derived classes, but it prepares them for future changes to `SimulatorConfig`. PiperOrigin-RevId: 684870508
copybara-service
bot
force-pushed
the
test_684273378
branch
from
0c5b733
to
de288c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move async interaction from
CoordinatortoBaseSimulator.This change adds asynchronous interaction to all simulators (i.e. derived
classes of
BaseSimulator), making this type of interaction less specificabout our specific usage in the
Coordinator. This is an ongoing effort toseparate the RL parts in AndroidEnv (mostly
AndroidEnvandTaskManager)from the more generic parts like
BaseSimulator. The interface of derivedclasses changed a little: instead of implementing
get_screenshot()they nowhave to implement
_get_screenshot_impl().This change also contains a small fix to
BaseSimulator.__init__()whichinstead of taking individual params, it now takes a single
SimulatorConfig,making its initialization the same as other major components. This requires a
small change to the
super().__init__()call in derived classes, but itprepares them for future changes to
SimulatorConfig.