Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use a custom slot refresher #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trojanowski
Copy link
Contributor

We're using a yield optimizer which requires us to use a proprietary function for refreshing slot instead of googletag.pubads().refresh() (for header bidding etc.). This PR allows that by specifying the slotRefresher property. googletag.pubads().refresh() is still used as the default one.

@seeden
Copy link
Collaborator

seeden commented Mar 21, 2019

@trojanowski are you still using this module? I am updating whole package and I am thinking about adding this feature. I realized that I am using your react-apollo-hooks library :) nice coincidence

@trojanowski
Copy link
Contributor Author

@trojanowski are you still using this module? I am updating whole package and I am thinking about adding this feature.

Yes, I do. I'm using my custom build right now because I need the feature from this PR. But it would be nice to use the official version from npm again. :)

I realized that I am using your react-apollo-hooks library :) nice coincidence

:)

@csims
Copy link

csims commented Oct 8, 2019

Hi @seeden ! I was wondering if there's still any interest in adding this feature. My team is currently using this library, but need to integrate with Amazon's Transparent Ad Marketplace for header bidding, so we're looking for the ability to use a custom slot refresher function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants