Add 2 letter state generator #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
reviewed
Nov 15, 2021
| @@ -26,6 +26,7 @@ describe('the default export', function () { | |||
| const values = ['a', 'b', 'c']; | |||
| expect(values).toContain(fake.sample(values)); | |||
| expect(fake.digit()).toEqual(expect.any(Number)); | |||
| expect(fake.state()).toEqual(expect.any(String)); | |||
There was a problem hiding this comment.
There's a comment at the top of this file that says this file shouldn't really exist! We should be adding new/updated tests to their own method-specific files.
Oh, which you did actually! So just remove this line please.
| @@ -245,6 +245,14 @@ Chooses one of the elements of the provided `array`. The given array cannot be e | |||
|
|
|||
| `() => string` | |||
|
|
|||
| Generates a random sentence beginning with a capitalized letter and ending with a period. | |||
|
|
|||
| #### `fake.state` | |||
There was a problem hiding this comment.
Perhaps preemptively nest this under fake.location? See #76.
This was referenced Nov 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the way we fake state codes in Garbanzo is to generate a random two letter string, without checking if it is a state or not (see here). It would be more convenient if fake-eggs handled this.