Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split-SSH formula that uses QVM tags #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gonzalo-bulnes
Copy link
Owner

@gonzalo-bulnes gonzalo-bulnes commented Sep 15, 2023

Prepares the release of qubes-mgmt-user-salt-split-ssh-2.0.0-1.

This version introduces breaking changes, as well as a new pattern of targeting _qubes_based on QVM tags (see #14).
In order to achieve the latter, the formula depends on another formula (qvm-tags-in-pillar) through an RPM dependency.

The RPM dependency ensures that the formula is available once this package is installed, but enabling it is still a manual step that is performed at the same time, and in the same way, as enabling the split-ssh formula. (See README in this PR.)

To do

  • Write this description
  • Document usage and list QVM tags to be used
  • Document dependency on qvm-tags-in-pillar, especially remind to enable top files
  • Add dependeency to RPM spec file Requires
  • Example scenarios?
  • Salt requires (for ordering, not needed for dependency management)

Testing

  • Installing the split-ssh package installs the qvm-tags-in-pillar package as a dependency
  • Both formulas as installed in the expected /srv/user_salt directories
  • Both can be enabled as expected

Out-of-scope questions

  • Uninstalling the split-ssh package suggests to uninstall the qvm-tags-in-pillar package as well?
  • What about disabling the formulas before uninstalling?

@gonzalo-bulnes
Copy link
Owner Author

gonzalo-bulnes commented Sep 15, 2023

@bcduggan Here's a preview 😉 (new vs old)

The two versions have roughly the same flexibility when it comes to configuration of which qubes have which roles, but the new version expects existing qubes with tags, while the old one was creating named qubes.

Let me know if that looks like what you've been thinking / using. I suspect it could be very close. 🙂

Note: The RPM spec is not complete, because it should declare a dependency on qubes-mgmt-salt-user-qvm-tags-in-pillar. (And the question of having that top file enabled is pending, I'm not sure yet what is best to do there.) And as you'll see, there are FIXME labels here and there in the supporting files. "Preview."

@gonzalo-bulnes gonzalo-bulnes force-pushed the add-split-ssh-formula-that-uses-qvm-tags branch from 8eb2e9a to 3160bae Compare September 28, 2023 10:19
@gonzalo-bulnes gonzalo-bulnes marked this pull request as ready for review September 28, 2023 12:09
@gonzalo-bulnes gonzalo-bulnes force-pushed the add-split-ssh-formula-that-uses-qvm-tags branch from 7afabd6 to efb6408 Compare September 28, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant