Add aad auth option when using azure storage account #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilverdewBaker
changed the title
|
Hi @matt0x6F, @nrwiersma could you please review this pr? |
|
@SilverdewBaker absolutely! Can you fill out the "how you fixed it summary? I'll start taking a look at the code but I don't have a lot of context on Azure. |
|
Taking a look at this this week; I was on vacation last week so apologies for the delayed response |
|
[heart] Yuelu Huan reacted to your message:
…________________________________
From: Matt ***@***.***>
Sent: Monday, July 8, 2024 5:35:54 PM
To: gomods/athens ***@***.***>
Cc: Yuelu Huan ***@***.***>; Mention ***@***.***>
Subject: Re: [gomods/athens] Add aad auth option when using azure storage account (PR #1973)
Taking a look at this this week; I was on vacation last week so apologies for the delayed response
—
Reply to this email directly, view it on GitHub<#1973 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANHSNJNES5UY6FKSULQWGP3ZLLEXVAVCNFSM6AAAAABKLDKQDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUG44TEMJUGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Azure blob can only be authenticated with storage account key now, this is not complaint in Microsoft, so this PR is adding a managed identity authentication option.
How is the fix applied?
Get the managed identity resource id and azure storage resource to get authentication from managed identity.
Here is the official document about managed identity usage in azure storage:
What GitHub issue(s) does this PR fix or close?
Fixes #