Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link and format on the experimental public proxy #1864

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

ColumbiaMancera
Copy link
Contributor

What is the problem I am trying to address?

Issue with the documentation, I'm trying to fix a faulty link.

On the section titled "More Details Please!" and specifically the sentence "There is currently an experimental public proxy (at https://athens.azurefd.net/) that you can use to try out Athens", whenever I try to access the page it gives me a blank page with the message "Welcome to The Athens Proxy". I'd currently change this message to "There is currently an experimental public proxy in development that you can use to try out Athens...". I'd like to be assigned to this issue and I'll be submitting a PR to solve it.

How is the fix applied?

I've adapted the text in the README.md to explain the experimental public proxy is a work in progress and also put a hyperlink over the text.

What GitHub issue(s) does this PR fix or close?

#1863

Fixes #

Fixes #1863

@ColumbiaMancera ColumbiaMancera requested a review from a team as a code owner April 1, 2023 03:50
Copy link
Contributor

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussing this in the issue before review.

Copy link
Contributor

@marwan-at-work marwan-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove the entire paragraph because we don't have one anymore?

@ColumbiaMancera
Copy link
Contributor Author

ColumbiaMancera commented May 10, 2023

We should probably remove the entire paragraph because we don't have one anymore?

If there currently isn't one anymore and the docs are outdated, then I think we should probably remove it! I've done so below.

@DrPsychick DrPsychick added this to the 0.13.0 milestone May 11, 2023
@DrPsychick DrPsychick merged commit c169a60 into gomods:main Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with link in README.MD
4 participants