Skip to content

Commit

Permalink
Fix AWS default credentials (#1963)
Browse files Browse the repository at this point in the history
Fix a bug where default credentials were erroneously cleared out, which broke several implementations.
  • Loading branch information
yongzhang committed May 23, 2024
1 parent 87ebcbe commit 0e1af85
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/storage/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ func New(s3Conf *config.S3Config, timeout time.Duration, options ...func(*aws.Co
return nil, errors.E(op, err)
}

// Remove anonymous credentials from the default config so that
// session.NewSession can auto-resolve credentials from role, profile, env etc.
awsConfig.Credentials = nil

for _, o := range options {
o(&awsConfig)
}
Expand Down

0 comments on commit 0e1af85

Please sign in to comment.