Add SVG element #314
Merged
Add SVG element #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVG is now part of HTML 5 and the SVG element a valid top-level element. The other SVG element, however, do not stand on their own. https://html.spec.whatwg.org/dev/embedded-content-other.html#svg-0 Note: This does not match up with the definition of CommonMark HTML blocks. CommonMark does not recognize the SVG element as a HTML block. In this respect, however, it would seem that CommonMark is lagging behind. https://spec.commonmark.org/0.31.2/#html-blocks
|
OK, so the test now shows that a lone RECT element does not get special treatment. It's only the SVG element that does. |
|
Thanks. Nitpick: the test could be shorter (one function, data driven, since they only differ in input / exp string), but it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG is now part of HTML 5 and the SVG element a valid top-level element. The other SVG element, however, do not stand on their own. https://html.spec.whatwg.org/dev/embedded-content-other.html#svg-0
Note: This does not match up with the definition of CommonMark HTML blocks. CommonMark does not recognize the SVG element as a HTML block. In this respect, however, it would seem that CommonMark is lagging behind. https://spec.commonmark.org/0.31.2/#html-blocks