Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bold/strong nested inside italics/em #307

Closed
wants to merge 5 commits into from
Closed

Handle bold/strong nested inside italics/em #307

wants to merge 5 commits into from

Commits on May 2, 2024

  1. When bold nested inside italics, skip the bold markers as we shouldn'… 

    …t treat them as the italics marker

This is giving us left-to-right precedence for applying styles (which is why the one existing test case changed)
    @cddude229
    cddude229 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a9ad544 View commit details
    Browse the repository at this point in the history

  2. Check length == 0 after checking the value of the next characters 

    This is a feedback loop from the "is next character c?" check.  Without this move, we may as well just `return 0, nil` from the "is next character c?" check.

This is an explicit edge case of ending with a triple
    @cddude229
    cddude229 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e161098 View commit details
    Browse the repository at this point in the history

  3. Skip two symbols if coming from emph3, which will handle the reverse … 

    …bold and italics ordering case
    @cddude229
    cddude229 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9e52993 View commit details
    Browse the repository at this point in the history

  4. Typo fix

    @cddude229
    cddude229 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    46938c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge branch 'master' into chris-patch-nested-italics-and-bold

    @kjk
    kjk authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    eda51b6 View commit details
    Browse the repository at this point in the history