Fix: respect DisableTags in OutTag func #301
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the issue
I was checking how
DisableTags
works and I think intention of the autor was to disable HTML tags completely.However at the moment when this field was set, only closing tags were removed.
Reproduction
I added
after line https://github.com/gomarkdown/markdown/blob/master/cmd/printast/main.go#L56
and copied content of the
README.md
intoexample.md
(these are first few lines of
README.md
)after my changes it seems to work correctly
(I have tested this on entire
README.md
content, here for readability I only included partial sample).Motivations
I'm proposing this fix for 2 reasons: