Skip to content

all: replace ioutil.ReadDir #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions go/buildutil/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"go/parser"
"go/token"
"io"
"io/ioutil"
"io/fs"
"os"
"path"
"path/filepath"
Expand Down Expand Up @@ -180,7 +180,23 @@ func ReadDir(ctxt *build.Context, path string) ([]os.FileInfo, error) {
if ctxt.ReadDir != nil {
return ctxt.ReadDir(path)
}
return ioutil.ReadDir(path)
return GetFileInfos(path)
}

func GetFileInfos(path string) ([]os.FileInfo, error) {
entries, err := os.ReadDir(path)
if err != nil {
return nil, err
}
infos := make([]fs.FileInfo, 0, len(entries))
for _, entry := range entries {
info, err := entry.Info()
if err != nil {
continue
}
infos = append(infos, info)
}
return infos, nil
}

// SplitPathList behaves like filepath.SplitList,
Expand Down
5 changes: 3 additions & 2 deletions godoc/vfs/os.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ package vfs
import (
"fmt"
"go/build"
"io/ioutil"
"os"
pathpkg "path"
"path/filepath"
"runtime"
"slices"

"golang.org/x/tools/go/buildutil"
)

// We expose a new variable because otherwise we need to copy the findGOROOT logic again
Expand Down Expand Up @@ -100,5 +101,5 @@ func (root osFS) Stat(path string) (os.FileInfo, error) {
}

func (root osFS) ReadDir(path string) ([]os.FileInfo, error) {
return ioutil.ReadDir(root.resolve(path)) // is sorted
return buildutil.GetFileInfos(root.resolve(path)) // is sorted
}
4 changes: 2 additions & 2 deletions internal/imports/fix.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import (
"go/token"
"go/types"
"io/fs"
"io/ioutil"
"os"
"path"
"path/filepath"
Expand All @@ -30,6 +29,7 @@ import (
"maps"

"golang.org/x/tools/go/ast/astutil"
"golang.org/x/tools/go/buildutil"
"golang.org/x/tools/internal/event"
"golang.org/x/tools/internal/gocommand"
"golang.org/x/tools/internal/gopathwalk"
Expand Down Expand Up @@ -1081,7 +1081,7 @@ func (e *ProcessEnv) buildContext() (*build.Context, error) {
// HACK: setting any of the Context I/O hooks prevents Import from invoking
// 'go list', regardless of GO111MODULE. This is undocumented, but it's
// unlikely to change before GOPATH support is removed.
ctx.ReadDir = ioutil.ReadDir
ctx.ReadDir = buildutil.GetFileInfos

return &ctx, nil
}
Expand Down