New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: remove unused errString type #241

Closed

thaJeztah wants to merge 1 commit into golang:master from thaJeztah:win_deadcode

Contributor

thaJeztah commented Dec 24, 2024 •

edited

Loading

It's no longer used since CL 165759.


          windows: remove unused errString type

3f0c460

It's no longer used since CL 165759

gopherbot commented Dec 24, 2024

This PR (HEAD: 3f0c460) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/638716.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot commented Dec 24, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 24, 2024

Message from Sebastiaan van Stijn:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 24, 2024

Message from Jorropo:

Patch Set 2: Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 24, 2024

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-24T20:54:55Z","revision":"58a77b94176be39421274fd5fcb92e1e81e47987"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 24, 2024

Message from Jorropo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 24, 2024

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 24, 2024

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 24, 2024

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 24, 2024

Message from Jorropo:

Patch Set 2: Auto-Submit+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 26, 2024

Message from Ian Lance Taylor:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 26, 2024

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-26T00:00:36Z","revision":"58a77b94176be39421274fd5fcb92e1e81e47987"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 26, 2024

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Dec 26, 2024

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/638716.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          windows: remove unused errString type

680bd24

It's no longer used since CL 165759.

Change-Id: Ie8c834a6dd1147889ec47bf92a5d4cce08bbf4fd
GitHub-Last-Rev: 3f0c460
GitHub-Pull-Request: #241
Reviewed-on: https://go-review.googlesource.com/c/sys/+/638716
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Jorropo <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Jorropo <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>

gopherbot commented Dec 26, 2024

This PR is being closed because golang.org/cl/638716 has been merged.

gopherbot closed this

thaJeztah deleted the win_deadcode branch

December 26, 2024 16:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet