-
Notifications
You must be signed in to change notification settings - Fork 18.7k
math/big: add floor and ceiling operations to Int and Rat #76820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
57522f4 to
036359e
Compare
|
This PR (HEAD: 036359e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
036359e to
9568524
Compare
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
|
This PR (HEAD: 9568524) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
|
Message from armin: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
|
Message from Alan Donovan: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
|
Message from Alan Donovan: Patch Set 2: Hold+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
9568524 to
2c73cb1
Compare
|
This PR (HEAD: 2c73cb1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
|
Message from armin: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
|
Message from Alan Donovan: Patch Set 3: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
2c73cb1 to
6d15cd9
Compare
|
This PR (HEAD: 6d15cd9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
|
Message from armin: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
|
Message from Alan Donovan: Patch Set 4: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
d816696 to
1dc4596
Compare
|
This PR (HEAD: 1dc4596) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
|
Message from armin: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/729860. |
1dc4596 to
1f9ea5e
Compare
|
This PR (HEAD: 1f9ea5e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
1f9ea5e to
a8bcbf1
Compare
|
This PR (HEAD: a8bcbf1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
a8bcbf1 to
3c16bd5
Compare
|
This PR (HEAD: 3c16bd5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
Adds methods FloorDiv, FloorDivMod, CeilDiv and CeilDivMod to Int. Adds methods Floor and Ceil to Rat. Fixes golang#76821
3c16bd5 to
e8ca293
Compare
|
This PR (HEAD: e8ca293) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/729860. Important tips:
|
Adds methods FloorDiv, FloorDivMod, CeilDiv and CeilDivMod to Int.
Adds methods Floor and Ceil to Rat.
Fixes #76821