Add fuzz test for CellUnion #193
Open
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And jointly fixing panic that can happen for bad input. Slice creation with n < 0 panics.
jmr
reviewed
Jun 29, 2025
| @@ -553,7 +553,7 @@ func (cu *CellUnion) encode(e *encoder) { | |||
| } | |||
| } | |||
|
|
|||
| // Decode decodes the CellUnion. | |||
| // Decode decodes the CellUnion. The resulting CellUnion is not check for validity. | |||
There was a problem hiding this comment.
Typo: "is not checked"
Probably clearer to explicitly mentionIsValid though.
jmr
reviewed
Jun 29, 2025
| @@ -570,7 +570,7 @@ func (cu *CellUnion) decode(d *decoder) { | |||
| return | |||
| } | |||
| n := d.readInt64() | |||
| if d.err != nil { | |||
| if d.err != nil || n < 0 { | |||
There was a problem hiding this comment.
What do C++/Java do? Should this be read as uint64 / should the error be updated like below?
jmr
reviewed
Jun 29, 2025
|
|
||
| func FuzzDecodeCellUnion(f *testing.F) { | ||
| cuCells := CellUnion([]CellID{ | ||
| CellID(0x33), |
There was a problem hiding this comment.
Do these cells matter at all? How were they generated?
jmr
reviewed
Jun 29, 2025
| // Construction failed, no need to test further. | ||
| return | ||
| } | ||
| if got := c.ApproxArea(); got < 0 { |
There was a problem hiding this comment.
Why are you testing 0 but not 4 pi? What if the union isn't valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And jointly fixing panic that can happen for bad input. Slice creation with n < 0 panics. Starting point for #175